Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local.properties from git index #96

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Remove local.properties from git index #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc05788
remove local.properties from git index, changes were still being trac…
Feb 8, 2024
8b18907
missed variable
Feb 8, 2024
96364c3
Merge branch 'master' into ecm/local-properties
evan-masseau Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ def localProperties = new Properties()
if (rootProject.file("local.properties").canRead()) {
localProperties.load(new FileInputStream(rootProject.file("local.properties")))
}
def reactNativeVersion = localProperties['reactNativeAndroidVersion'] ?: ""
def reactNativeAndroidVersion = localProperties['reactNativeAndroidVersion'] ?: ""


dependencies {
if (reactNativeVersion) {
if (reactNativeAndroidVersion) {
// For local development of the SDK code, specify the react-android version to use
// So that the SDK can be built and .kt files are linted against a real version of react-native
implementation "com.facebook.react:react-android:$reactNativeVersion"
implementation "com.facebook.react:react-android:$reactNativeAndroidVersion"
} else {
// Production build / once embedded in a react-native app,
// the react-native version gets loaded in from the application dependencies.
Expand Down
5 changes: 3 additions & 2 deletions android/local.properties → android/local.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## Changes in this file must *NOT* be tracked by Version Control Systems,
# as it contains information specific to your local configuration.
# Only the base template should be checked in to VCS.
# Copy this file to `local.properties` to set your local overrides

## Uncomment for local SDK development, so that gradle can locate the
## Used for local SDK development, so that gradle can locate the
# correct RN version outside the context of an application
#reactNativeAndroidVersion=0.73.1
reactNativeAndroidVersion=0.73.1
3 changes: 2 additions & 1 deletion example/android/local.properties → example/android/local.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
# as it contains information specific to your local configuration,
# such as your Klaviyo company ID aka "Public API Key".
# Only the base template should be checked in to VCS.
# Copy this file to `local.properties` to set your local overrides

#publicApiKey=YOUR_PUBLIC_API_KEY
publicApiKey=YOUR_PUBLIC_API_KEY