use retry after instead of calculating delay #166
Conversation
| @@ -112,7 +112,7 @@ func handleRequestError( | |||
| case let .retryWithBackoff(requestCount, totalCount, _): | |||
| requestRetryCount = requestCount + 1 | |||
| totalRetryCount = totalCount + 1 | |||
| nextBackoff = getDelaySeconds(for: totalRetryCount) | |||
| nextBackoff = retryAfter ?? getDelaySeconds(for: totalRetryCount) | |||
There was a problem hiding this comment.
Should we apply jitter to the retryAfter too?
There was a problem hiding this comment.
I suppose if we needed jitter, the server could apply it.
There was a problem hiding this comment.
@jason-myers-klaviyo do you have any opinion on whether the SDKs should apply a jitter on top of the Retry-After value? Does the Retry-After just represent the time till the steady state rate limit "resets" or is there more advanced logic to it?
There was a problem hiding this comment.
Jitter longer than the seconds given would be fine and up to you. Nice to have I think
Jitter shorter will cause another 429 I think
There was a problem hiding this comment.
It is just the time until the steady windows reset IIRC
There was a problem hiding this comment.
Oh ya definitely only add jitter
|
For viz, the relevant android PR |
Added jitter to |
Description
Check List
Manual Test Plan
Supporting Materials