TP157110: Add requirement for lowest supported php version #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavesj
approved these changes
Jan 9, 2023
cykolln
reviewed
Jan 23, 2023
There was a problem hiding this comment.
given version 4.0.0+ of our extension is only compatible with magento versions 2.4.0+ we should go off of the minimum php version requirement for that m2 version which would be 7.3. However, I don't know if it's best practice to specify php version in extension composer.json files - let me look into this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds our currently lowest supported version as a requirement in our composer.json file.
Manual Testing Steps
Pre-Submission Checklist: