Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update response handling for false #282

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented Dec 13, 2023

Description

This PR fixes behavior for when curl_exec returns something that is not explicitly false but evaluates to false (ex: null). This will prevent successful responses from retrying and follows the recommendation here: https://www.php.net/manual/en/function.curl-exec.php#refsect1-function.curl-exec-returnvalues

Manual Testing Steps

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner December 13, 2023 18:26
@cykolln cykolln merged commit bd2d63e into master Dec 13, 2023
3 checks passed
@cykolln cykolln deleted the 202312_update_response_handling branch December 13, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants