Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds urlencode to email before search request #299

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented May 22, 2024

Description

Fixes a bug where we weren't url encoding emails before requesting the api/profiles/ endpoint. For emails containing special characters this was resulting in misses on the search and the following request to create the new profile would fail because it does already exist.

Manual Testing Steps

  1. Selected to not use Klaviyo's opt-in settings in the extension settings. Then filled out the M2 footer form with an email that already existed in Klaviyo, made sure it was properly added to list.
  2. Tested the same as above but with a new email that didn't exist in Klaviyo.

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner May 22, 2024 15:48
@cykolln
Copy link
Contributor Author

cykolln commented May 22, 2024

Fixes #295

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@cykolln cykolln merged commit 587580b into master May 22, 2024
3 checks passed
@cykolln cykolln deleted the 202405_BUGPORT-2384 branch May 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants