Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space key to start/stop acquisition #55

Closed
dzid26 opened this issue May 3, 2024 · 2 comments
Closed

Space key to start/stop acquisition #55

dzid26 opened this issue May 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dzid26
Copy link
Contributor

dzid26 commented May 3, 2024

Nice to have.

@klonyyy klonyyy self-assigned this May 4, 2024
@klonyyy klonyyy added the enhancement New feature or request label May 4, 2024
@klonyyy klonyyy added this to MCUViewer May 4, 2024
@klonyyy klonyyy added this to the J-Link HSS support milestone May 4, 2024
@klonyyy klonyyy moved this to In Progress in MCUViewer May 4, 2024
@dzid26
Copy link
Contributor Author

dzid26 commented May 4, 2024

I saw your commit.

In addition I was also looking at using io.ConfigFlags |= ImGuiConfigFlags_NavEnableKeyboard; (which is nice in itself for navigating toolbar menu) with ImGui::SetKeyboardFocusHere(0); (placed before start button).

It creates this pretty frame around the start button, and it is visible that the button is being pressed. But it flickers, since the focus is called all the time and interferes with toolbar navigation.

This may not be possible to solve easily.

Also related:
ocornut/imgui#5606 (comment)

@klonyyy
Copy link
Owner

klonyyy commented May 5, 2024

I think navigation using the keyboard is a secondary task, as most people using STMViewer I know, are primarily navigating with the mouse. Let's see if the issue gains more attention in the future. I'll close it for now but feel free to reopen, vote for adding such feature or contribute to implement it.

@klonyyy klonyyy closed this as completed May 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MCUViewer May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants