Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A constant map is used to pass constants #968

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

A constant map is used to pass constants #968

wants to merge 2 commits into from

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@LiZhenCheng9527
change a constant map to pass var
e180c32 
Signed-off-by: LiZhenCheng9527 <[email protected]>
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.97%. Comparing base (1f2940b) to head (d076de3).
Report is 21 commits behind head on main.

Files with missing lines Coverage Δ
pkg/bpf/ads/loader.go 46.05% <100.00%> (-8.79%) ⬇️
pkg/bpf/workload/loader.go 33.33% <100.00%> (-6.93%) ⬇️

... and 69 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b8028...d076de3. Read the comment docs.

hzxuzhonghu
hzxuzhonghu reviewed Oct 18, 2024
View reviewed changes
bpf/include/bpf_log.h Outdated
@@ -47,7 +47,7 @@ struct {
__uint(max_entries, 1);
__uint(key_size, sizeof(__u32));
__uint(value_size, sizeof(__u32));
} bpf_log_level SEC(".maps");
} constant_map SEC(".maps");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a worse name without concrete meaning

@kmesh-bot kmesh-bot added size/S and removed size/XS labels Oct 18, 2024
@LiZhenCheng9527
remove constant_map to common.h
d076de3 
Signed-off-by: LiZhenCheng9527 <[email protected]>
@LiZhenCheng9527
Copy link
Collaborator Author

#977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@Okabe-Rintarou-0 Okabe-Rintarou-0 Awaiting requested review from Okabe-Rintarou-0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiZhenCheng9527 @kmesh-bot @hzxuzhonghu