Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-plane]: Use filtered informer to watch OIDC service accounts #3655

Closed
creydr opened this issue Jan 31, 2024 · 5 comments · Fixed by #3719
Closed

[control-plane]: Use filtered informer to watch OIDC service accounts #3655

creydr opened this issue Jan 31, 2024 · 5 comments · Fixed by #3719
Assignees

Comments

@creydr
Copy link
Contributor

creydr commented Jan 31, 2024

Currently we're watching all service accounts in the cluster for changes and reenque the objects which have an OIDC service account assigned if something changes:

// Reconciler Trigger when the OIDC service account changes
serviceaccountInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterController(&eventing.Trigger{}),
Handler: controller.HandleAll(impl.EnqueueControllerOf),
})

and

serviceaccountInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterController(&eventing.Trigger{}),
Handler: controller.HandleAll(impl.EnqueueControllerOf),
})

Instead we should use a filtered service account informer as done in knative/eventing#7341

Additional information:

@yijie-04
Copy link
Contributor

/assign

@karkabbage
Copy link
Contributor

/assign

@creydr
Copy link
Contributor Author

creydr commented Feb 20, 2024

Hello @karkabbage and @yijie-04,
any updates on this? Do you need any more information to get started with this?

@karkabbage
Copy link
Contributor

Hi @creydr , thanks for checking in!
From what I understand, I'll be following mostly from #7527 to change similar files for the trigger controllers.

@creydr
Copy link
Contributor Author

creydr commented Feb 26, 2024

Hi @creydr , thanks for checking in! From what I understand, I'll be following mostly from #7527 to change similar files for the trigger controllers.

Hello @karkabbage,
yes. It will be similar to what was done in knative/eventing#7527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants