-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use filtered informer to watch OIDC service accounts #3719
Conversation
|
Welcome @karkabbage! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉 |
Hi @karkabbage. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
=============================================
- Coverage 73.70% 53.93% -19.78%
+ Complexity 875 850 -25
=============================================
Files 100 343 +243
Lines 3419 18219 +14800
Branches 292 291 -1
=============================================
+ Hits 2520 9826 +7306
- Misses 723 7458 +6735
- Partials 176 935 +759
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @karkabbage, |
Hi @creydr , |
/ok-to-test |
/retest |
@knative-prow-robot /retest |
/retest |
@karkabbage @yijie-04 do you need any more information or help besides #3719 (comment)? |
…ces a trigger for correct broker class
/test upgrade-tests |
…only, if SA references a trigger for correct broker class
/retest-required |
@@ -101,7 +99,7 @@ func hasNoKafkaBrokerFinalizer() func(ctx context.Context, t feature.T) { | |||
time.Sleep(time.Second * 20) // "eventually" | |||
tr := triggerfeatures.GetTrigger(ctx, t) | |||
for _, f := range tr.Finalizers { | |||
require.NotEqual(t, f, triggerreconciler.FinalizerName, "%+v", tr) | |||
require.NotEqual(t, f, "kafka.triggers.eventing.knative.dev", "%+v", tr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the need for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full context is here: #3719 (comment).
TL;DR; is, that this lead to an import an then registered an informer, which lead to a test failure in this case.
Co-authored-by: Calum Murray <[email protected]>
/test reconciler-tests |
1 similar comment
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, karkabbage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest-required |
/retest-required |
/test integration-tests |
6c4665c
into
knative-extensions:main
Fixes #3655
Proposed Changes
Release Note
Docs