Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: knative kafka extensions are short enough to meet the SHOULD req in spec #3994

Closed
wants to merge 1 commit into from
Closed

fix: knative kafka extensions are short enough to meet the SHOULD req in spec #3994

wants to merge 1 commit into from

Conversation

Cali0707
Copy link
Member

Fixes #3992

Proposed Changes

  • Shorten the extensions

Release Note

BREAKING CHANGE: the knative kafka partition/offset ce extensions have been renamed to knkafkapartition and knkafkaoffset to keep them under 20 characters in length

@knative-prow knative-prow bot added area/data-plane area/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@Cali0707
Copy link
Member Author

/cc @matzew @Leo6Leo @aliok

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.15%. Comparing base (8c82715) to head (ce44054).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3994   +/-   ##
=======================================
  Coverage   48.15%   48.15%           
=======================================
  Files         246      246           
  Lines       14517    14517           
=======================================
  Hits         6990     6990           
  Misses       6821     6821           
  Partials      706      706

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707 Cali0707 force-pushed the shorten-kn-partition-extension branch from cbcd8c7 to ce44054 Compare July 18, 2024 18:02
@matzew
Copy link
Contributor

matzew commented Jul 19, 2024

/retest

matzew
matzew reviewed Jul 19, 2024
View reviewed changes
...a/dev/knative/eventing/kafka/broker/dispatcher/impl/consumer/CloudEventOverridesMutator.java
@@ -46,7 +46,7 @@ private void applyCloudEventOverrides(CloudEventBuilder builder) {
}

private void applyKafkaMetadata(CloudEventBuilder builder, Number partition, Number offset) {
builder.withExtension("knativekafkapartition", partition);
builder.withExtension("knativekafkaoffset", offset);
builder.withExtension("knkafkapartition", partition);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cali0707 can you check w/ the Java SDK why it is not failing on 20+ chars?
(and maybe double check w/ golang)?

matzew
matzew approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
this seems breaking change. should we do something there? Or is release-notes good enought (I guess it is good enought). Just wondering

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 19, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main ce44054 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member

/hold

I'm worried this will break users, given that it is a should is it really worth it? I think the JS SDK should not throw for this as it's a SHOULD

@Cali0707
Copy link
Member Author

I'm worried this will break users, given that it is a should is it really worth it? I think the JS SDK should not throw for this as it's a SHOULD

Sure, let me try opening a PR to the SDK to fix that

@Cali0707
Copy link
Member Author

I opened cloudevents/sdk-javascript#593

@matzew
Copy link
Contributor

matzew commented Jul 25, 2024

@Cali0707 closing.

the fix in JS seems better addressing this SHOULD.

/close

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 25, 2024

@matzew: Closed this PR.

In response to this:

@Cali0707 closing.

the fix in JS seems better addressing this SHOULD.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane area/test do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

knativekafkapartition CE extension does not conform to spec
3 participants
@Cali0707 @matzew @pierDipi