-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add autoscaling list command #29
add autoscaling list command #29
Conversation
@maximilien and @zhanggbj: I closed PR #17 because I can't make e2e test pass after I rebased it with three previous PRs. So I updated my master to latest and added |
@chaozbj : Could you try opening a fresh PR rebased onto current main branch and see if the github workflow update is picked up ? (I still see the UT are being run with go 1.15, while we downgraded that to 1.14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update. Better PR. Left a few comments. Please try to address.
Also any chance for adding an e2e test?
ok, no problem |
Signed-off-by: chaozbj <[email protected]>
Signed-off-by: chaozbj <[email protected]>
Signed-off-by: chaozbj <[email protected]>
741c824
to
f16a2fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 77.63% 78.76% +1.13%
==========================================
Files 19 20 +1
Lines 921 1003 +82
==========================================
+ Hits 715 790 +75
- Misses 152 156 +4
- Partials 54 57 +3
Continue to review full report at Codecov.
|
Signed-off-by: chaozbj <[email protected]>
Signed-off-by: chaozbj <[email protected]>
@maximilien @navidshaikh @zhanggbj I addressed all comments and make UT and e2e passed, please help to review, thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaozbj, maximilien, zhanggbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Thanks @chaozbj for the efforts. Looks good to me. |
LGTM so will let others a chance to comment |
/unhold |
Add
autoscaling list
command.