Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autoscaling list command #29

Merged
merged 5 commits into from
Dec 11, 2020
Merged

add autoscaling list command #29

merged 5 commits into from
Dec 11, 2020

Conversation

chaozbj
Copy link
Contributor

@chaozbj chaozbj commented Dec 4, 2020 •
edited
Loading

Add autoscaling list command.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 4, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2020
@chaozbj
Copy link
Contributor Author

chaozbj commented Dec 4, 2020 •
edited
Loading

@maximilien and @zhanggbj: I closed PR #17 because I can't make e2e test pass after I rebased it with three previous PRs. So I updated my master to latest and added autoscaling list back, and now the test is passed. Please help me to review. Thanks!

@navidshaikh
Copy link
Contributor

@chaozbj : Could you try opening a fresh PR rebased onto current main branch and see if the github workflow update is picked up ? (I still see the UT are being run with go 1.15, while we downgraded that to 1.14)

maximilien
maximilien approved these changes Dec 8, 2020
View reviewed changes
Copy link

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update. Better PR. Left a few comments. Please try to address.

Also any chance for adding an e2e test?

pkg/command/autoscaling/list.go Show resolved Hide resolved
pkg/command/autoscaling/list_test.go Show resolved Hide resolved
test/e2e/kn_admin_test.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@chaozbj
Copy link
Contributor Author

chaozbj commented Dec 9, 2020

@chaozbj : Could you try opening a fresh PR rebased onto current main branch and see if the github workflow update is picked up ? (I still see the UT are being run with go 1.15, while we downgraded that to 1.14)

ok, no problem

@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #29 (3b56b7f) into master (ab40d9d) will increase coverage by 1.13%.
The diff coverage is 91.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   77.63%   78.76%   +1.13%     
==========================================
  Files          19       20       +1     
  Lines         921     1003      +82     
==========================================
+ Hits          715      790      +75     
- Misses        152      156       +4     
- Partials       54       57       +3
Impacted Files Coverage Δ
pkg/command/autoscaling/autoscaling.go 0.00% <0.00%> (ø)
pkg/command/autoscaling/list.go 92.59% <92.59%> (ø)
pkg/command/autoscaling/update.go 69.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab40d9d...e7fce23. Read the comment docs.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 10, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@chaozbj
Copy link
Contributor Author

chaozbj commented Dec 10, 2020

@maximilien @navidshaikh @zhanggbj I addressed all comments and make UT and e2e passed, please help to review, thanks!

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaozbj, maximilien, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,zhanggbj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhanggbj
Copy link

/lgtm
/hold

Thanks @chaozbj for the efforts. Looks good to me.
Hold for 1 day if there're any further comments from reviewers. If no, we can merge it.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@maximilien
Copy link

LGTM so will let others a chance to comment

@zhanggbj
Copy link

/unhold
Merging it!

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2020
@knative-prow-robot knative-prow-robot merged commit eaeb388 into knative-extensions:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@zhanggbj zhanggbj zhanggbj approved these changes

@grantr grantr Awaiting requested review from grantr

Assignees

@zhanggbj zhanggbj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chaozbj @navidshaikh @knative-prow-robot @zhanggbj @maximilien