Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable update test #1112

Merged
merged 1 commit into from
May 24, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented May 23, 2023

This test is very flakey and hindering contributions to this repo - we need fix this but in the meantime let's disable it

See: #938

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2023
@dprotaso dprotaso mentioned this pull request May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1112 (06f8c69) into main (05d9f2d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files          18       18           
  Lines        1652     1652           
=======================================
  Hits         1352     1352           
  Misses        216      216           
  Partials       84       84           

@dprotaso
Copy link
Contributor Author

/assign @nak3 @psschwei

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@knative-prow
Copy link

knative-prow bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b6bc3ca into knative-extensions:main May 24, 2023
@dprotaso dprotaso deleted the disable-update-e2e branch May 24, 2023 17:46
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.10

@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.9

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #1121

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #1122

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants