Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase gateway memory limit #1236

Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Apr 2, 2024

Changes

  • Increase 3scale-kourier-gateway memory limit

Fixes knative/serving#15052

Release Note

The default memory limit of 3scale-kourier-gateway was increased to prevent OOMKilled on peak load scenarios

@knative-prow knative-prow bot requested a review from skonto April 2, 2024 06:16
Copy link

knative-prow bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@ReToCode
Copy link
Member Author

ReToCode commented Apr 2, 2024

/assign @skonto

Tested in knative/serving#15060.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (3655396) to head (6da3cc4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   60.63%   62.31%   +1.67%     
==========================================
  Files          24       24              
  Lines        2002     1632     -370     
==========================================
- Hits         1214     1017     -197     
+ Misses        726      553     -173     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Apr 3, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@skonto
Copy link
Contributor

skonto commented Apr 3, 2024

Do we know why we need this increase (besides flakes), what is the root cause of the overhead?

@ReToCode
Copy link
Member Author

ReToCode commented Apr 3, 2024

That we added more stuff to encryption, we are definitely creating more envoy config with this (thus, just the tls test were flaky).

@knative-prow knative-prow bot merged commit 9960e27 into knative-extensions:main Apr 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e/kind - kourier-tls tests are flakey
2 participants