WIP: Add IPv6 listener config option

[covert8]

Changes

Adds config option to enable listening on IPv6 (default false)

• 🐛 Enable listening on IPv6

/kind bug

Fixes #1299

Release Note

Add ability to change address family used for kourier listeners (default IPv4 value unchanged)

Docs

pending

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: covert8 / name: Louis R (cbc61b0, c3e7de2)

[knative-prow]

Welcome @covert8! It looks like this is your first PR to knative-extensions/net-kourier 🎉

[knative-prow]

Hi @covert8. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

Hi @covert8 thank you for the contribution!
Should we make this configurable as in Contour projectcontour/contour#4385.
For example be able to configure the address and the port instead of using a boolean?

[skonto]

/ok-to-test

[skonto]

We should expose the default value in the cm. We could have one for both http or https or be more flexible and have a different one if it makes sense. @ReToCode wdyth?

[ReToCode]

yeah makes sense, maybe not everybody wants to open it on all IPs. But we'd need two for IPv4 and IPv6 I think, as they could be different.

[covert8]

Thanks for the review. If I'm understanding it correctly, you'd like http/ipv4 https/ipv4 http/ipv6 https/ipv6 addresses to be supplied by the configmap?

[skonto]

Yeah that is right.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: covert8
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

@covert8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit-tests_net-kourier_main	cbc61b0	link	true	/test unit-tests
build-tests_net-kourier_main	cbc61b0	link	true	/test build-tests
integration-tests_net-kourier_main	cbc61b0	link	true	/test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.