Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus annotations to net-kourier #978

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

evankanderson
Copy link
Contributor

Changes

Fixes #957

  • 🎁 Adds prometheus scrape annotations for both controller and envoy pods.

Release Note

* Adds prometheus scraping annotations for net-kourier, so Prometheus Operator users should now be able to collect statistics automatically.

@knative-prow
Copy link

knative-prow bot commented Jan 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2023
@evankanderson
Copy link
Contributor Author

/assign @nak3 @psschwei @skonto

cc @aryan9600

(you can /lgtm even if you're not in the org if you want)

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Merging #978 (f7e9e58) into main (47f6d83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files          18       18           
  Lines        1330     1330           
=======================================
  Hits         1072     1072           
  Misses        205      205           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Jan 21, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2023
@knative-prow knative-prow bot merged commit 819b72f into main Jan 21, 2023
@dprotaso dprotaso deleted the add-prometheus branch March 1, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Prometheus monitoring annotations to envoy, for the cases where Prometheus is used.
4 participants