Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gate #57
Gate #57
Changes from 29 commits
ff2abea
b0f25d1
b80c3f1
ceb4fa1
47634cc
a9e412f
f77de08
ebe577e
909b5d9
501ed39
5034900
17d57a2
b815b08
f154ee6
6aa2d69
f13a27a
ad6ed73
bdfbf79
699af57
74f74ae
5240423
aa6f2f1
6abdac6
78e78b7
2f29942
ca2ea32
722b424
21a2803
4e7abe9
bf92ec5
68080b9
098db68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to double-check that this doesn't overwrite the existing config-deployment... might be better to just have the setup-guard-service script patch the existing configmap with the current QP image...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested by adding a
test: boom
parameter to config.deployment - this parameter remains when doing security-guardko apply -Rf ./config
while the image changes - note that the _example is removed after such a change.after
ko apply -Rf config/core
at servingafter
ko apply -Rf ./config
at security-guard