Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to cancel/abort a running PipelineRun without deleting the PipelineRun itself. #272

Closed
abayer opened this issue Nov 28, 2018 · 6 comments
Closed

Add the ability to cancel/abort a running PipelineRun without deleting the PipelineRun itself. #272

abayer opened this issue Nov 28, 2018 · 6 comments
Labels
design This task is about creating and discussing a design help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given

Comments

@abayer
Copy link
Contributor

abayer commented Nov 28, 2018

Expected Behavior

A user can cancel or abort a PipelineRun, causing all TaskRuns (and their associated Builds) within the PipelineRun to also cancel/abort, while preserving the PipelineRun and associated TaskRuns/Builds for reporting purposes.

Actual Behavior

PipelineRuns can only be canceled by deleting the CRD, eliminating any record of the canceled run.

Additional Info

This will require changes to Build CRD to allow for canceling a running Build.

Related to #222
@bobcatfish bobcatfish added design This task is about creating and discussing a design meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 30, 2018
@vdemeester
Copy link
Member

/assign

@abayer
Copy link
Contributor Author

abayer commented Dec 19, 2018

woo! I've been working on #222 off and on over the last week, and got stuck on figuring out how to cancel/abort a TaskRun (and associated Build) in the first place, so I'll be watching this closely. =)

@vdemeester
Copy link
Member

@abayer ah 🙃 well, let's see if I'm hitting a wall too or not 👼 😝

@abayer
Copy link
Contributor Author

abayer commented Dec 19, 2018

Well, at least then I wouldn't be the only one hitting a wall on this. =)

@vdemeester vdemeester mentioned this issue Dec 21, 2018
Merged
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Dec 27, 2018
@abayer
Add Pipeline-level timeouts
160ab59 
This still needs work - for example, it can't kill running Builds yet,
but I'm waiting for cancellation (i.e., tektoncd#272) to be a thing before
actually implementing that part.

Fixes tektoncd#222
@abayer abayer mentioned this issue Dec 27, 2018
Merged
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jan 22, 2019
@abayer
Add Pipeline-level timeouts
cd69e0f 
This still needs work - for example, it can't kill running Builds yet,
but I'm waiting for cancellation (i.e., tektoncd#272) to be a thing before
actually implementing that part.

Fixes tektoncd#222
@vdemeester
Copy link
Member

I think we can close this one as #510 is merged

/close

@knative-prow-robot
Copy link

@vdemeester: Closing this issue.

In response to this:

I think we can close this one as #510 is merged

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nikhil-thomas pushed a commit to nikhil-thomas/pipeline that referenced this issue Dec 26, 2019
@openshift-merge-robot
Merge pull request tektoncd#272 from chmouel/add-catalog-to-release-p…
595f809 
…rocess

Add pipeline-catalog release process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design This task is about creating and discussing a design help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vdemeester @abayer @bobcatfish @knative-prow-robot