This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix (build_validation) Incorrect field paths returned (#495)
* fixed field-paths returned for setting the Template field and also including Steps * switched to correct FieldError: ErrMultipleOneOf instead of disallowing Steps * changed errors: multiple sources and missing both template/steps * fixed field paths in build_validation.go, added comments around some extraneous code/potential bugs * fixed field-path for bad-kind in template, tested with unit test * added ViaField() to Template validation caller, chained a bunch of validation calls with .Also(), made the reciever variable for validateTimeOut bs in line with the rest of build_validation.go * addressed most of review comments, targetpath->targetPath * removed ViaField(source) from validateSources errors * fixed comment formatting * updated error sent back for target path validation * corrected fieldpaths for duplicate step names and multiple sources w/ subpaths * standardized volume validation error field path * Redid build_validation_test.go: check errors recieved against expected values, fixed bugs in Build Timeout tests * fixed targetPath validation tests to reflect the FieldError change * Added ErrOutOfBoundsValue for build timeout validation * including vendor updates for unit tests * rebased with upstream/master, fixed merge conflicts * ran update-codegen.sh
- Loading branch information
1 parent
14db3d4
commit 695fd25
Showing
19 changed files
with
343 additions
and
230 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.