Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Commit

Permalink
Fix a small type in build_test.go : createServceAccount 😅 (#508)
Browse files Browse the repository at this point in the history
Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Dec 19, 2018
1 parent ca5596a commit f11465b
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions pkg/reconciler/build/build_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func newBuild(name string) *v1alpha1.Build {
}
}

func (f *fixture) createServceAccount() {
func (f *fixture) createServiceAccount() {
f.t.Helper()
f.createServiceAccounts(&corev1.ServiceAccount{
ObjectMeta: metav1.ObjectMeta{Name: "default"},
Expand Down Expand Up @@ -123,7 +123,7 @@ func TestBuildNotFoundFlow(t *testing.T) {
client: fake.NewSimpleClientset(b),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

// induce failure when fetching build information in controller
reactor := func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
Expand Down Expand Up @@ -151,7 +151,7 @@ func TestBuildWithBadKey(t *testing.T) {
t: t,
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, _, _ := f.newReconciler()
if err := r.Reconcile(context.Background(), "bad/worse/worst"); err != nil {
Expand All @@ -167,7 +167,7 @@ func TestBuildNotFoundError(t *testing.T) {
client: fake.NewSimpleClientset(b),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, i, k8sI := f.newReconciler()
// Don't update build informers with test build object
Expand Down Expand Up @@ -287,7 +287,7 @@ func TestBuildWithNonExistentTemplates(t *testing.T) {
client: fake.NewSimpleClientset(b),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, i, k8sI := f.newReconciler()
f.updateIndex(i, b)
Expand Down Expand Up @@ -344,7 +344,7 @@ func TestBuildWithTemplate(t *testing.T) {
client: fake.NewSimpleClientset(b, tmpl),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, i, k8sI := f.newReconciler()
f.updateIndex(i, b)
Expand Down Expand Up @@ -437,7 +437,7 @@ func TestBasicFlows(t *testing.T) {
client: fake.NewSimpleClientset(b),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, i, k8sI := f.newReconciler()
f.updateIndex(i, b)
Expand Down Expand Up @@ -508,7 +508,7 @@ func TestTimeoutFlow(t *testing.T) {
client: fake.NewSimpleClientset(b),
kubeclient: k8sfake.NewSimpleClientset(),
}
f.createServceAccount()
f.createServiceAccount()

r, i, k8sI := f.newReconciler()
f.updateIndex(i, b)
Expand Down

0 comments on commit f11465b

Please sign in to comment.