Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Add integration test demonstrating use of PersistentVolumeClaims for inter-build caching #228

Closed
wants to merge 1 commit into from

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jul 6, 2018

Functional example of #52

Proposed Changes

  • Test defines a PersistentVolumeClaim which is attached first to a build that populates the cache, then another build reads the cache

Release Note

NONE

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@imjasonh
Copy link
Member Author

imjasonh commented Jul 6, 2018

/test pull-knative-build-integration-tests
/unassign srinivashegde86
/unassign steuhs
/assign mattmoor

@imjasonh
Copy link
Member Author

imjasonh commented Jul 6, 2018

/test pull-knative-build-integration-tests

Looks like this might be flaky on Prow? I didn't see any flakes after ~10 runs locally, but I guess if k8s schedules the second build before the first it won't see the cached content. Any ideas about how to order these builds better?

@mattmoor
Copy link
Member

cc @adrcunha

@mattmoor
Copy link
Member

Oh, I see the problem now. Let me think about it.

@imjasonh
Copy link
Member Author

Probably needs to be a real Go test like knative/serving has, that waits for things to become ready before doing the next thing.

@mattmoor
Copy link
Member

I got nothing that doesn't involve modifying the test harness (until we have a Pipeline CRD).

@imjasonh
Copy link
Member Author

Adding support for real Go tests has other advantages too like being able to track noop build latency in testgrid. I'll work on that after Next.

@mattmoor
Copy link
Member

@imjasonh you should sync with @srinivashegde86 who has been moving some of our common test code into knative/pkg to better enable this.

In the meantime, it might be interesting to write such a test in the knative/serving repo?

@imjasonh
Copy link
Member Author

imjasonh commented Oct 5, 2018

#341 instead

@imjasonh imjasonh closed this Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants