This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Dockerfile for new minimal base image based on alpine #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Aug 27, 2018
| @@ -0,0 +1,4 @@ | |||
| FROM alpine:latest | |||
|
|
|||
| RUN apk add --update git openssh-client | |||
There was a problem hiding this comment.
Should this run apk update too?
There was a problem hiding this comment.
I believe the --update flag fetches the current package index before adding the package.
For reference: https://github.com/gliderlabs/docker-alpine/blob/master/docs/usage.md
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, pivotal-nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
imjasonh
pushed a commit
to imjasonh/build
that referenced
this pull request
Sep 18, 2018
mattmoor
pushed a commit
that referenced
this pull request
Sep 18, 2018
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #179
Proposed Changes
.ko.yamlfile should be updated to point to itRelease Note