Extract the ApplyReplacements logic from ApplyTemplate. #415
Conversation
There was a problem hiding this comment.
@dlorenc: 0 warnings.
In response to this:
This functionality will be used in build-pipeline as well, and reusing
this logic will help ensure consistency.Should be used for tektoncd/pipeline#64
Proposed Changes
- Extract logic from ApplyTemplate into a new, public function
ApplyReplacementsRelease Note
NONE/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/assign @imjasonh |
This functionality will be used in build-pipeline as well, and reusing this logic will help ensure consistency.
dlorenc
force-pushed
the
extractreplacements
branch
from
3067513
to
7b505c1
Compare
|
The following is the coverage report on pkg/.
|
|
@shashwathi can i get an /approve as well? |
|
/approve (Sorry :( ) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc, shashwathi, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This functionality will be used in build-pipeline as well, and reusing this logic will help ensure consistency.
This functionality will be used in build-pipeline as well, and reusing this logic will help ensure consistency.
This functionality will be used in build-pipeline as well, and reusing
this logic will help ensure consistency.
Should be used for tektoncd/pipeline#64
Proposed Changes
ApplyReplacementsRelease Note
/lint