-
Notifications
You must be signed in to change notification settings - Fork 23
[kn-admin]Add e2e tests for kn admin plugin #63
Conversation
Hi @lanceliuu. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Lance Liu <[email protected]>
/ok-to-test |
Hi @evankanderson, would you please help to add @lanceliuu to knative org, he's mainly focused on knative/client-contrib now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the copyright.
I realize this is a DRAFT so leaving early feedback.
Can you please provide a description and perhaps a TODO list of the tests you plan to do. That will help review and you executing. Thanks.
cc @zhanggbj
@lanceliuu you can add your tests plan as a TODO / tasks list in the description of this PR. |
/retest |
Signed-off-by: Lance Liu <[email protected]>
/retest |
Signed-off-by: Lance Liu <[email protected]>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lanceliuu, zhanggbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
per offline discussion with @lanceliuu, this PR is the initial e2e setup and only cover domain subcommand. CC @maximilien who helped to review this PR^^^ |
OK @zhanggbj. Let's also edit the description of this PR and removing the unfinished TODOs and move them to the other list if not there. /lgtm |
Hi @maximilien @daisy-ycguo @rhuss The integration tests failed due to service creation failure. The Knative Ingress never becomes ready, it could be an error of e2e cluster side, any suggestions?
|
/test pull-knative-client-contrib-integration-tests @lanceliuu can you dig into why above ^^^ is failing? thx. |
E2E tests need to fill-up: