Skip to content

Commit

Permalink
e2e: Foreground delete for revisions and services in e2e
Browse files Browse the repository at this point in the history
 to avoid any race conditions and flakes
  • Loading branch information
navidshaikh committed Apr 10, 2020
1 parent 030279b commit 129573e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/e2e/basic_workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func serviceUpdate(r *test.KnRunResultCollector, serviceName string, args ...str
}

func serviceDelete(r *test.KnRunResultCollector, serviceName string) {
out := r.KnTest().Kn().Run("service", "delete", serviceName)
out := r.KnTest().Kn().Run("service", "delete", "--no-wait=false", serviceName)
r.AssertNoError(out)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace()))
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/revision_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func revisionListWithService(r *test.KnRunResultCollector, serviceNames ...strin
}

func revisionDelete(r *test.KnRunResultCollector, revName string) {
out := r.KnTest().Kn().Run("revision", "delete", revName)
out := r.KnTest().Kn().Run("revision", "delete", "--no-wait=false", revName)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace()))
r.AssertNoError(out)
}
Expand Down

0 comments on commit 129573e

Please sign in to comment.