Skip to content

Commit

Permalink
Some fixes in kn domain help messages (#1283)
Browse files Browse the repository at this point in the history
  • Loading branch information
rhuss authored Apr 6, 2021
1 parent 3f1a238 commit 33e2c9f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
8 changes: 8 additions & 0 deletions docs/cmd/kn_domain_describe.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ Show details of a domain mapping
kn domain describe NAME
```

### Examples

```
# Show details of for the domain 'hello.example.com'
kn domain describe hello.example.com
```

### Options

```
Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_domain_list.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ kn domain list
kn domain list
# List all domain mappings in JSON output format
kn revision list -o json
kn domain list -o json
```

### Options
Expand Down
3 changes: 3 additions & 0 deletions pkg/kn/commands/domain/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ func NewDomainMappingDescribeCommand(p *commands.KnParams) *cobra.Command {
cmd := &cobra.Command{
Use: "describe NAME",
Short: "Show details of a domain mapping",
Example: `
# Show details of for the domain 'hello.example.com'
kn domain describe hello.example.com`,
RunE: func(cmd *cobra.Command, args []string) error {
if len(args) != 1 {
return errors.New("'kn domain describe' requires name of the domain mapping as single argument")
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/domain/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func NewDomainMappingListCommand(p *commands.KnParams) *cobra.Command {
kn domain list
# List all domain mappings in JSON output format
kn revision list -o json`,
kn domain list -o json`,
RunE: func(cmd *cobra.Command, args []string) error {
namespace, err := p.GetNamespace(cmd)
if err != nil {
Expand Down

0 comments on commit 33e2c9f

Please sign in to comment.