Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for tagging revisions #232

Closed
navidshaikh opened this issue Jul 5, 2019 · 4 comments
Closed

Add command for tagging revisions #232

navidshaikh opened this issue Jul 5, 2019 · 4 comments
Assignees
@navidshaikh
Labels
kind/feature New feature or request
Milestone
v0.9.0

Comments

@navidshaikh
Copy link
Collaborator

This is followup issue of #231, the idea is to introduce leaf command for labeling revisions.
Couple of verb choices: tag, label
I personally like kn revision tag.
@navidshaikh
Copy link
Collaborator Author

/assign @navidshaikh

@rhuss
Copy link
Contributor

rhuss commented Jul 5, 2019

I definitley all for tag to avoid any confustion with metadata.labels

@sixolet sixolet added this to the v0.8.0 milestone Jul 9, 2019
@sixolet sixolet added the kind/feature New feature or request label Jul 11, 2019
@maximilien
Copy link
Contributor

Yup. We had that in knctl. Should be also useful for how we end up doing #210.

@rhuss rhuss changed the title Add command for labeling revisions Add command for tagging revisions Jul 12, 2019
@navidshaikh navidshaikh mentioned this issue Jul 24, 2019
Closed
@sixolet
Copy link
Contributor

sixolet commented Aug 15, 2019

Fixed by #345

@sixolet sixolet closed this as completed Aug 15, 2019
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Update OWNERS with new team members (knative#232)
daf96ed
dsimansk pushed a commit to dsimansk/client that referenced this issue Oct 2, 2023
@openshift-cherrypick-robot @Kaustubh-pande
add myself to OWNERS (knative#232)
af98fca 
Co-authored-by: Kaustubh Pande <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navidshaikh navidshaikh

Labels
kind/feature New feature or request
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
4 participants
@maximilien @rhuss @sixolet @navidshaikh