-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for revision existance when updating traffic #445
Comments
Revision existence check was originally planned with traffic splitting implementation (first check list item for #345), but then IIUC we took off that being in scope of server side validation for resource existence (knative/serving#5094). The issue is tagged for serving v0.10.x due Oct 29.
We can introduce this (and deprecate when we've server side validation for this). |
The issue currently is that the long timeout of 10 mins introduced in |
Looks like this can be closed as the server-side bug has been fixed?
|
Good point, thanks for the heads up. |
When the traffic distribution is updated e.g. via
and if the revision does not exist (note the typo here with
latest
instead of@latest
, then the update hangs because the service waits for this revision to exists before becomingReady
(but this will be never the case). So either the server should already go into an error state or as this doesn't seem to be the case, the client should refuse to create traffic targets to revisions that do not exist.The text was updated successfully, but these errors were encountered: