-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a message on stdout after service create #87
Comments
I can do this too if you are not addressing. LMK. |
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
May 8, 2019
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
May 9, 2019
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
May 10, 2019
Fixes knative#87 Aligns the service delete info message with service create too.
knative-prow-robot
pushed a commit
that referenced
this issue
May 14, 2019
* Adds info message after service create operation Fixes #87 Aligns the service delete info message with service create too. * Updates per review comments Adds newline after std imports Line breaks at proper operator
maximilien
pushed a commit
to maximilien/client
that referenced
this issue
May 14, 2019
) * Adds info message after service create operation Fixes knative#87 Aligns the service delete info message with service create too. * Updates per review comments Adds newline after std imports Line breaks at proper operator
maximilien
pushed a commit
to maximilien/client
that referenced
this issue
May 14, 2019
) * Adds info message after service create operation Fixes knative#87 Aligns the service delete info message with service create too. * Updates per review comments Adds newline after std imports Line breaks at proper operator
maximilien
pushed a commit
to maximilien/client
that referenced
this issue
May 14, 2019
) * Adds info message after service create operation Fixes knative#87 Aligns the service delete info message with service create too. * Updates per review comments Adds newline after std imports Line breaks at proper operator
coryrc
pushed a commit
to coryrc/client
that referenced
this issue
May 14, 2020
`kubectl` 1.11 doesn't recognize the `--username` and `--password` flags anymore. Because the `prow-tests` image uses `kubectl` 1.8, the Prow jobs are not broken (yet). The changes in knative#86 don't work because the context is not changed (nor restored), but the function works as long as the current user is an owner of the GCP project (which is not the case for Prow E2E test jobs). This change creates and uses a new context for the cluster admin, created the role binding, then switches back to the original context. This is more secure as no ACL changes are required for the current user, nor project wide ACL changes are performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kn service create
returns without any hint, lets add a message about service creation status.For eg:
Created <SERVICE_NAME> in namespace.
The text was updated successfully, but these errors were encountered: