fix(service): Show URL (external) instead of Address (internal) when listing service #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
navidshaikh
reviewed
Jul 9, 2019
rhuss
force-pushed
the
pr/service-list-fix
branch
from
d6de493
to
5b10a2d
Compare
navidshaikh
approved these changes
Jul 9, 2019
| @@ -25,8 +25,8 @@ import ( | |||
| // ServiceListHandlers adds print handlers for service list command | |||
| func ServiceListHandlers(h hprinters.PrintHandler) { | |||
| kServiceColumnDefinitions := []metav1beta1.TableColumnDefinition{ | |||
| {Name: "Name", Type: "string", Description: "Name of the knative service."}, | |||
| {Name: "Domain", Type: "string", Description: "Domain name of the knative service."}, | |||
| {Name: "Name", Type: "string", Description: "Name of the Knative service."}, | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhuss
changed the title
rhuss
force-pushed
the
pr/service-list-fix
branch
from
5b10a2d
to
fb69f8d
Compare
knative-prow-robot
added
size/M
…g service Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then. This fix should work with 0.6.0, too as the new fields already have been populated back then. So we can unconditionally pick status.address.url which is accordance with our policy to support the latest release and the release before. Fixes knative#246.
rhuss
force-pushed
the
pr/service-list-fix
branch
from
fb69f8d
to
bc10bbf
Compare
|
/lgtm |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
This makes the context of the message more clear (for example, during a release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.
This fix should work with 0.6.0, too as the new fields already have been populated back then.
So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.
Fixes #246.