fixes(#414): change plugins config keys to use - instead of camel case #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/M
navidshaikh
reviewed
Oct 2, 2019
rhuss
reviewed
Oct 2, 2019
rhuss
approved these changes
Oct 2, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This solves 414 by adopting new format for config keys and thereby bypassing the need for case sensitivity in Viper. Also changed `lookupPluginsInPath` key to `lookup-plugins` and also same for the persistent flag. The PATH part is implied and can be read from help.
|
/test pull-knative-client-integration-tests-latest-release |
|
/lgtm |
maximilien
added a commit
to maximilien/client
that referenced
this pull request
Oct 8, 2019
…ase (knative#428) This solves 414 by adopting new format for config keys and thereby bypassing the need for case sensitivity in Viper. Also changed `lookupPluginsInPath` key to `lookup-plugins` and also same for the persistent flag. The PATH part is implied and can be read from help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Proposed Changes
lookupPluginsInPathkey tolookup-pluginsand also same for the persistent flag. The PATH part is implied and can be read from help.Release Note: