Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor): partial fix for issue #763 by refactoring common e2e code #764

Closed
wants to merge 1 commit into from
Closed

(refactor): partial fix for issue #763 by refactoring common e2e code #764

wants to merge 1 commit into from

Conversation

maximilien
Copy link
Contributor

Description

Addresses the e2e part of issue #763. Moves common code to lib\test\integration

Changes

  • refactors the common e2e code into lib\test\integration
  • change package name of the common code from e2e to integration
  • change all e2e test to use new common code

Reference

Partially fix to issue #763

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
@knative-prow-robot
Copy link
Contributor

@maximilien: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2020
@maximilien
Copy link
Contributor Author

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 27, 2020
mattmoor
mattmoor reviewed Mar 27, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

lib/test/integration/flags.go Outdated Show resolved Hide resolved
lib/test/integration/integration.go Show resolved Hide resolved
lib/test/integration/result_collector.go Outdated Show resolved Hide resolved
lib/test/integration/result_collector.go Show resolved Hide resolved
lib/test/integration/result_collector.go Outdated Show resolved Hide resolved
test/e2e/sinkprefix_test.go Outdated Show resolved Hide resolved
test/e2e/sinkprefix_test.go Show resolved Hide resolved
test/e2e/source_apiserver_test.go Outdated Show resolved Hide resolved
test/e2e/source_list_test.go Outdated Show resolved Hide resolved
test/e2e/source_list_test.go Show resolved Hide resolved
@maximilien
Copy link
Contributor Author

/retest

@knative-prow-robot
Copy link
Contributor

@maximilien: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-go-coverage 241757d link /test pull-knative-client-go-coverage
pull-knative-client-integration-tests-latest-release 241757d link /test pull-knative-client-integration-tests-latest-release
pull-knative-client-build-tests 241757d link /test pull-knative-client-build-tests
pull-knative-client-unit-tests 241757d link /test pull-knative-client-unit-tests
pull-knative-client-integration-tests 241757d link /test pull-knative-client-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maximilien
Copy link
Contributor Author

Closing this so I can resubmit. Forgot to gofmt new lib directory

@maximilien maximilien closed this Mar 27, 2020
@maximilien maximilien deleted the issue763_e2e branch March 27, 2020 03:18
dsimansk added a commit to dsimansk/client that referenced this pull request Aug 3, 2021
@dsimansk
[release-v0.23.2] Update CI setup, tests and func (knative#764)
9a1667c 
* Revert "Switch Eventing setup from OSS to release branch"

This reverts commit 7399fcc.

* Add kn-plugin-source-kafka e2e tests

* Add spec file

* Update func to latest main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximilien @knative-prow-robot @mattmoor @googlebot