fix(769): various issues with godoc documents #771
Conversation
There was a problem hiding this comment.
@maximilien: 0 warnings.
In response to this:
Description
Fixes various godoc comments that are not conforming as well as some /lint issues that came up
Changes
- correct signatures for some functions with with non-conforming names
- various corrections to Godoc comments for exported code in new lib/test
- fix CHANGELOG.doc for new location for common test code
Reference
Fixes #769
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
approved
|
/ok-to-test |
knative-prow-robot
added
the
ok-to-test
| @@ -33,7 +33,7 @@ type Kn struct { | |||
| namespace string | |||
| } | |||
|
|
|||
| // New Kn object | |||
| // NewKn object | |||
There was a problem hiding this comment.
| // NewKn object | |
| // NewKn creates a new Kn object |
| @@ -68,7 +68,7 @@ func (test *KnTest) Teardown() error { | |||
| return DeleteNamespace(test.namespace) | |||
| } | |||
|
|
|||
| // Teardown clean up | |||
| // Kn object used by this KnTest | |||
There was a problem hiding this comment.
| // Kn object used by this KnTest | |
| // Kn returns object used by this KnTest |
| validateUserId(t, it, r, "svc6", uid) | ||
| validateUserID(t, it, r, "svc6", uid) | ||
| serviceUpdate(t, it, r, "svc6", "--user", strconv.FormatInt(uid+1, 10)) | ||
| validateUserId(t, it, r, "svc6", uid+1) | ||
| validateUserID(t, it, r, "svc6", uid+1) | ||
| } |
| @@ -50,7 +50,7 @@ func TestSourceApiServer(t *testing.T) { | |||
| r := test.NewKnRunResultCollector(t) | |||
| defer r.DumpIfFailed() | |||
|
|
|||
| setupForSourceApiServer(t, it) | |||
| setupForSourceAPIServer(t, it) | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nits, nits, nits. :)
Description
Fixes various godoc comments that are not conforming as well as some /lint issues that came up
Changes
Reference
Fixes #769
/lint