Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we switch to SPDX-License-Identifiers? #517

Closed
dprotaso opened this issue Mar 5, 2021 · 8 comments
Closed

Can we switch to SPDX-License-Identifiers? #517

dprotaso opened this issue Mar 5, 2021 · 8 comments
Assignees

Comments

@dprotaso
Copy link
Member

dprotaso commented Mar 5, 2021

ie. instead of the full license we use

// SPDX-License-Identifier: Apache-2.0

/assign @thisisnotapril

@dprotaso
Copy link
Member Author

dprotaso commented Mar 5, 2021

April said she'll consult the lawyercats

/meow

@knative-prow-robot
Copy link
Contributor

@dprotaso: cat image

In response to this:

April said she'll consult the lawyercats

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

dprotaso commented Mar 5, 2021

wow that's a creepy cat

@thisisnotapril
Copy link
Contributor

lol when did Prow decide to add cat pictures?? this is amazing.

@thisisnotapril
Copy link
Contributor

From legal - we can use SPDX in addition to the standard license template, but can't just use SPDX. There is no real authority backing up the idea that SPDX notifiers are an effective instrument for communicating the licensing of a given file; hence best practice is to use the full license header so nothing is ambiguous.

@rhuss
Copy link
Contributor

rhuss commented Mar 9, 2021

@thisisnotapril thanks for clarifying ! As I think the intention was to reduce the noise in source files, we should not add SPDX in addition, right ? (so maybe we can close this issue for now @dprotaso ).

@dprotaso
Copy link
Member Author

Chatted with April - this is still ongoing.

What's notable is that the apache 2 license guidance says using SPDX is fine: http://www.apache.org/foundation/license-faq.html#Apply-My-Software

K8s is figuring out their story: cncf/foundation#143

@thisisnotapril
Copy link
Contributor

Update: best practice is still going to be to use the standard license header. K8s is doing the same; preference is for the full license header. As the SPDX benefit is minor; removing about 8 lines of code; it's better to spell things out fully. Our legal has already seen examples where the top-level license doesn't match up with the SPDX, or copyright bits removed; etc - their stance is it's best to be safe and use the full header so it's fully spelled out.

daisy-ycguo pushed a commit to daisy-ycguo/community that referenced this issue Mar 12, 2021
for istio.io English - (Frank and Nathan were from prior team).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants