Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello world samples for Go, Node, and CSharp #11

Merged
merged 15 commits into from
Jun 22, 2018
Merged

Hello world samples for Go, Node, and CSharp #11

merged 15 commits into from
Jun 22, 2018

Conversation

rgregg
Copy link
Contributor

@rgregg rgregg commented Jun 22, 2018

No description provided.

Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mchmarny mchmarny merged commit f288609 into knative:master Jun 22, 2018
@google-prow-robot
Copy link

@mchmarny: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mchmarny, rgregg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rgregg rgregg deleted the ryan-samples-1 branch June 27, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants