Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly point out not installing ns-cert component for http01 challenge #2890

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Explicitly point out not installing ns-cert component for http01 challenge #2890

merged 3 commits into from
Oct 12, 2020

Conversation

ZhiminXiang
Copy link

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2020
nak3
nak3 reviewed Oct 7, 2020
View reviewed changes
docs/serving/using-auto-tls.md Outdated
@@ -154,6 +154,10 @@ and which DNS provider validates those requests.

If you choose to use the mode of provisioning certificate per namespace, you need to install `networking-ns-cert` components.

**Note that provisioning certificate per namespace only works with DNS-01
challenge. If you choose to use HTTP-01 challenge, you must NOT install this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, ns-cert for HTTP-01 is under development? Or it will never support HTTP-01?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will never support HTTP01 as the namespace-level cert is wildcard cert which can only works with DNS01.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thank you.

@nak3
Copy link
Contributor

nak3 commented Oct 7, 2020

/lgtm

Just one small question.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@nak3
Copy link
Contributor

nak3 commented Oct 7, 2020

/assign @abrennan89

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@google-cla
Copy link

google-cla bot commented Oct 7, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 7, 2020
abrennan89
abrennan89 suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the format so it looks more like other notes 🙂
@RichieEscarez can we look into introducing some CSS formatting or something for the site to add notes that stand out visually? Something like https://www.w3schools.com/w3css/w3css_notes.asp

@abrennan89 abrennan89 added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 7, 2020
@google-cla
Copy link

google-cla bot commented Oct 7, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot removed the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@abrennan89
Copy link
Contributor

@ZhiminXiang if you accept the suggestion I think you need to force push to fix the CLA thing, sorry 😞

abrennan89
abrennan89 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez
Copy link
Contributor

Updated the format so it looks more like other notes 🙂
@RichieEscarez can we look into introducing some CSS formatting or something for the site to add notes that stand out visually? Something like https://www.w3schools.com/w3css/w3css_notes.asp

Opened issue here to track that enhancement (also includes info for others to attempt the change): knative/website#228

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2020
@google-cla
Copy link

google-cla bot commented Oct 10, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Oct 10, 2020
@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 10, 2020
@abrennan89
Copy link
Contributor

/lgtm
Thanks @ZhiminXiang !

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@abrennan89 abrennan89 added this to the v0.19.0 milestone Oct 12, 2020
@knative-prow-robot knative-prow-robot merged commit 0f436f9 into knative:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichieEscarez RichieEscarez RichieEscarez left review comments

@nak3 nak3 nak3 left review comments

@abrennan89 abrennan89 abrennan89 approved these changes

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@nak3 nak3

@abrennan89 abrennan89

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ZhiminXiang @nak3 @abrennan89 @knative-prow-robot @RichieEscarez @googlebot