Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configure-kn.md to include channel-type-mappings and add comments to sample yaml #5591

Merged
merged 2 commits into from
Aug 1, 2023
Merged

update configure-kn.md to include channel-type-mappings and add comments to sample yaml #5591

merged 2 commits into from
Aug 1, 2023

Conversation

garg-dhruv
Copy link
Contributor

Proposed Changes

  • Add 'channel-type-mappings' customisation option to Customizing kn docs.
    This feature already existed and was documented as part of the github docs for kn-client, but was missing from the official website. Please take a look at this comment.
  • Also, replaced the config yaml with a better-commented version of the same, which already existed as part of the github docs for kn-client.

@netlify
Copy link

netlify bot commented Jun 4, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20da8ae
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64c8cdee0f8eb20008874f9e
😎 Deploy Preview https://deploy-preview-5591--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Jun 4, 2023

Welcome @garg-dhruv! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 4, 2023
@garg-dhruv
Copy link
Contributor Author

/assign @dsimansk

@skonto
Copy link
Contributor

skonto commented Jul 13, 2023

cc @rhuss

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, maybe update the example version as @dsimansk suggest. Then we are good to merge.

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2023

/approve
/lgtm
/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/approve
/lgtm
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, garg-dhruv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@knative-prow knative-prow bot merged commit 70708b0 into knative:main Aug 1, 2023
16 checks passed
@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #5646

In response to this:

/approve
/lgtm
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants