Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document current behaviour of scaling down with activation scale #5619

Merged

Conversation

xtreme-vikram-yadav
Copy link

The changes in this PR only reflect the existing behaviour of scale down operation by autoscaler when activation scale is set until the behaviour is changed in future.

Related Issue: knative/serving#14017

@knative-prow knative-prow bot requested review from csantanapr and nainaz July 5, 2023 23:21
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2023
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 77801ee
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64a5fb0c702744000827f15a
😎 Deploy Preview https://deploy-preview-5619--knative.netlify.app/docs/serving/autoscaling/scale-bounds
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei, xtreme-vikram-yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@knative-prow knative-prow bot merged commit 21ce192 into knative:main Jul 7, 2023
@xtreme-vikram-yadav xtreme-vikram-yadav deleted the update-activation-scale-docs branch July 10, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants