Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect goimports properly #5656

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Redirect goimports properly #5656

merged 2 commits into from
Aug 3, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Aug 3, 2023

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

  • Completing org changes from knative-sandbox to knative-extensions

/cc @matejvasek

@upodroid upodroid requested a review from dprotaso August 3, 2023 17:57
@knative-prow knative-prow bot requested a review from matejvasek August 3, 2023 17:57
@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit 711bd18
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64cbf421e9d8af00086103ec
😎 Deploy Preview https://deploy-preview-5656--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 3, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2023
@upodroid upodroid mentioned this pull request Aug 3, 2023
Merged
@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@knative-prow knative-prow bot merged commit 7d53fd6 into main Aug 3, 2023
26 checks passed
@dprotaso dprotaso deleted the go-import-patch branch August 4, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @krsna-m @knative-prow-robot