Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Kafka Binding doc and its references #5684

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

CodesbyUnnati
Copy link
Contributor

Fixes #5682

Proposed Changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CodesbyUnnati / name: Unnati Mishra (7a508dd)

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7a508dd
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6502a9a98ca12e0008acbb46
😎 Deploy Preview https://deploy-preview-5684--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Sep 14, 2023

Welcome @CodesbyUnnati! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2023
@pierDipi
Copy link
Member

Thanks @CodesbyUnnati

@CodesbyUnnati
Copy link
Contributor Author

Hi @csantanapr @pmbanugo Can you please review this PR 😄

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CodesbyUnnati, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@knative-prow knative-prow bot merged commit 661e572 into knative:main Sep 18, 2023
20 checks passed
@pierDipi
Copy link
Member

/cherry-pick release-1.11

@pierDipi
Copy link
Member

/cherry-pick release-1.10

@knative-prow-robot
Copy link
Contributor

@pierDipi: #5684 failed to apply on top of branch "release-1.11":

Applying: Removed Kafka Binding doc and its references
Using index info to reconstruct a base tree...
M	code-samples/eventing/kafka/binding/README.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): code-samples/eventing/kafka/binding/README.md deleted in Removed Kafka Binding doc and its references and modified in HEAD. Version HEAD of code-samples/eventing/kafka/binding/README.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Removed Kafka Binding doc and its references
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: #5684 failed to apply on top of branch "release-1.10":

Applying: Removed Kafka Binding doc and its references
Using index info to reconstruct a base tree...
M	code-samples/eventing/kafka/binding/README.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): code-samples/eventing/kafka/binding/README.md deleted in Removed Kafka Binding doc and its references and modified in HEAD. Version HEAD of code-samples/eventing/kafka/binding/README.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Removed Kafka Binding doc and its references
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KafkaBinding documentation code sample
3 participants