Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and reword auto-tls feature to external-domain-tls #5692

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Sep 21, 2023

Partially knative/serving#14368

Proposed Changes

  • Rename auto-tls to external-domain-tls
  • Reword the existing pages to prepare for the future flags we introduce
    • Make it more clear that the current feature is only for external domains
    • Point to our existing work to bring HTTPS to cluster-local domains as well
  • Remove duplications about installing cert-manager
  • Reorder the navigation to have a new section for encryption. We'll add an overview page to that section to explain the three different parts of Serving Encryption in the future
  • Rename pages to better reflect what they are trying to explain

Review links for changed pages:

/hold - work in networking/serving is not merged yet

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8c17e9f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/650d2d80b99eb6000804cabe
😎 Deploy Preview https://deploy-preview-5692--knative.netlify.app/docs/serving
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@knative-prow knative-prow bot requested review from aliok and nainaz September 21, 2023 13:27
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2023
@ReToCode ReToCode requested review from dprotaso, nak3 and skonto and removed request for aliok and nainaz September 21, 2023 13:35
@ReToCode
Copy link
Member Author

Depends on this merged: knative/networking#858

@ReToCode
Copy link
Member Author

ReToCode commented Oct 3, 2023

/unhold as networking PR is merged

/assign @nak3
/assign @dprotaso
/assign @skonto

@ReToCode
Copy link
Member Author

ReToCode commented Oct 4, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 5, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@knative-prow knative-prow bot merged commit 6d93813 into knative:main Oct 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants