Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings and update CSS #5741

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Oct 30, 2023

Changes

Fixes #5723

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 97d6bbc
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653fa39e22bc43000801145a
😎 Deploy Preview https://deploy-preview-5741--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@ReToCode
Copy link
Member Author

@nak3 @pmbanugo should now be fine, please take a look at the preview to see if you find any problems.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@nak3
Copy link
Contributor

nak3 commented Nov 5, 2023

/lgtm

Thank you!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2023
@knative-prow knative-prow bot merged commit 4727b76 into knative:main Nov 5, 2023
18 of 19 checks passed
@ReToCode
Copy link
Member Author

ReToCode commented Nov 6, 2023

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5748

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from materialx.emoji.twemoji to material.extensions.emoji.twemoji
4 participants