Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the use of HTTP/1 full duplex support #5818

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Document the use of HTTP/1 full duplex support #5818

merged 2 commits into from
Jan 23, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 17, 2024 •
edited
Loading

Proposed Changes

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68c5b66
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65afb66cb6ba980008480b4e
😎 Deploy Preview https://deploy-preview-5818--knative.netlify.app/docs/serving/services/http-protocol
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2024
@knative-prow knative-prow bot requested a review from nak3 January 17, 2024 13:57
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@skonto skonto removed the request for review from nak3 January 17, 2024 18:10
ReToCode
ReToCode reviewed Jan 18, 2024
View reviewed changes
docs/serving/services/http-protocol.md Outdated
...
```

!!! warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would move that to the top of the YAML. Other than that LGTM

dprotaso
dprotaso reviewed Jan 18, 2024
View reviewed changes
docs/serving/services/http-protocol.md
name: example-service
namespace: default
annotations:
features.knative.dev/http-full-duplex: "Enabled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the casing matter? eg. I assume "enabled" works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this specific case, but usually all our flags are string.EqualFold'ded.

ReToCode
ReToCode approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f653815 into knative:main Jan 23, 2024
19 checks passed
@skonto skonto mentioned this pull request Jan 29, 2024
Merged
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@skonto @prushh
Document the use of HTTP/1 full duplex support (knative#5818)
d5f97a0 
* document the use of http/1 full duplex support

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@ReToCode ReToCode ReToCode approved these changes

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skonto @dprotaso @ReToCode