Sample app frontend #5931
Sample app frontend #5931
Conversation
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
Welcome @ctmphuongg! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
bot
added
the
size/XXL
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @Leo6Leo |
knative-prow
bot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
@ctmphuongg Thank you for your PR Phuong! It looks great to me overall, just left few comments! PTAL, and let me know if you have any questions!
code-samples/eventing/bookstore-sample-app/frontend/public/images/Bookcover.png
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/pages/Main.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentDisplay.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentDisplay.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentDisplay.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Great work @ctmphuongg !
I suggested some changes to make it look more align with the design graph.
After apply these changes, it looks like this on my end.
code-samples/eventing/bookstore-sample-app/frontend/client/pages/Main.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/BookDetail.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentList.js
Outdated
Show resolved
Hide resolved
…es/Main.js Co-authored-by: Leo Li <[email protected]>
…ponents/BookDetail.js Co-authored-by: Leo Li <[email protected]>
There was a problem hiding this comment.
Great work @ctmphuongg ! Please see the comments and let me know if you have any questions!
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentDisplay.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/Toggle.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/SubmitButton.js
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/app/favicon.ico
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/app/page.tsx
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/frontend/client/components/CommentList.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The README.md looks great! But just a note here: it might need to be changed when the sample app approaches to the end!! If it got changed, it doesn't mean your README.md is wrong!!
|
Thanks @ctmphuongg! This looks great! |
…ponents/Toggle.js Co-authored-by: Leo Li <[email protected]>
There was a problem hiding this comment.
This looks great to me! Thank you for the amazing work @ctmphuongg !
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ctmphuongg, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
* Add darkmode * Edit README * Add comments and readme * Fix UI * Update README * Update code-samples/eventing/bookstore-sample-app/frontend/client/pages/Main.js Co-authored-by: Leo Li <[email protected]> * Update code-samples/eventing/bookstore-sample-app/frontend/client/components/BookDetail.js Co-authored-by: Leo Li <[email protected]> * Change emoji * Update code-samples/eventing/bookstore-sample-app/frontend/client/components/Toggle.js Co-authored-by: Leo Li <[email protected]> * Fix UI * Align time --------- Co-authored-by: Leo Li <[email protected]>
"Fixes #5899"
Proposed Changes
Frontend of sample app for Knative eventing. Packages used: Next.js, node.js, TailwindCSS, next-themes
In some components, I assume receiving an object with the defined attributes and make example objects using const. This will be changed when connected to backend and know backend object format.
Remaining problems:
Please look at other parts of the code and let me know if you need any changes. For the component CommentDisplay, please let me know if you have any suggestions as well. Thank you!
Current UI:
