Add the readme for sample app codes, and update the code-sample page #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page to include bookstore app
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/L
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cali0707
reviewed
Jul 18, 2024
| @@ -9,6 +9,7 @@ Knative code samples that are actively tested and maintained by Knative working | |||
|
|
|||
| - [Eventing and Eventing Sources code samples](eventing.md) | |||
| - [Serving code samples](serving.md) | |||
| - [E2E Sample Application - Knative Bookstore](https://github.com/knative/docs/tree/main/code-samples/eventing/bookstore-sample-app) | |||
There was a problem hiding this comment.
Nit: maybe we can indicate that this uses serving and eventing and functions? The other items in this list mention serving/eventing so it can be a little confusing to figure out which is used from just the text here
|
/cc @Cali0707 |
Cali0707
approved these changes
Jul 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Note: the link to the sample app tutorial pages will show as "Page note found" for now, it will be functional until Knative release 1.15 is out.