Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sampleconsistency test #6118

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix sampleconsistency test #6118

merged 1 commit into from
Sep 16, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Sep 16, 2024 •
edited
Loading

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 808dae5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66e8237914a96a00081cc9ea
😎 Deploy Preview https://deploy-preview-6118--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pierDipi
pierDipi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a265dce into knative:main Sep 16, 2024
19 checks passed
@skonto skonto mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@ReToCode ReToCode Awaiting requested review from ReToCode

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

Assignees

@mgencur mgencur

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skonto @pierDipi @mgencur