Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #6129

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix broken links #6129

merged 1 commit into from
Sep 26, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Sep 26, 2024

Check CI for failures

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 996428f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66f4fa2926c08a000819c46c
😎 Deploy Preview https://deploy-preview-6129--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ali Ok <[email protected]>
@aliok aliok changed the title Check CI for failures Fix broken links Sep 26, 2024
@aliok
Copy link
Member Author

aliok commented Sep 26, 2024

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@aliok: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

knative-prow bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a9d24a0 into knative:main Sep 26, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@aliok: new pull request created: #6130

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aliok aliok deleted the 2024-09-26-fix-ci branch September 26, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants