Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match sampleconsistency_test check #6141

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Oct 21, 2024

Fixes Test / test / Unit Tests check (see #6140)

Proposed Changes

  • bump the version of express in README.md file of helloworld-nodejs sample project to match constraint

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 667cffb
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67167a0c9b34250008ec29f9
😎 Deploy Preview https://deploy-preview-6141--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prushh
Copy link
Contributor Author

prushh commented Oct 21, 2024

@Cali0707 Feel free to close this PR!
Then I will sync the other with the main branch.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, prushh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2024
@knative-prow knative-prow bot merged commit db30b9d into knative:main Oct 21, 2024
19 checks passed
@prushh prushh deleted the fix-unit-test branch October 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants