Improve Kafka retry

[matzew]

Expected Behavior

• proper retry

Actual Behavior

Currently if there is a message not dispatched to the "consumer", it is not committed:
https://github.com/knative/eventing-contrib/blob/master/kafka/common/pkg/kafka/consumer_handler.go#L80

A failed message is than not correcty reprocessed, if the next one is successful ..

Additional Info

[slinkydeveloper]

I was wondering, if we move the actual event dispatch in another goroutine pool, then when a message for any reason is not sent, we could just re-enqueue it in the channel between the consumers pool and the dispatcher pool

[matzew]

+1

On Tue 17. Sep 2019 at 10:10, Francesco Guardiani ***@***.***> wrote: I was wondering, if we move the actual event dispatch in another goroutine pool, then when a message for any reason is not sent, we could just re-enqueue it in the channel between the consumers pool and the dispatcher pool — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#596?email_source=notifications&email_token=AABGPTVSXRTO2FCQO2YHIE3QKCGIXA5CNFSM4IXCZ3Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD63WFJA#issuecomment-532112036>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABGPTUPD7XKI2N5AYSXVITQKCGIXANCNFSM4IXCZ3QQ> .

-- Sent from Gmail Mobile

[lionelvillard]

/milestone 0.10.0

[knative-prow-robot]

@lionelvillard: You must be a member of the knative/knative-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 0.10.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

Does #1114 solve/relate to this issue?

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[slinkydeveloper]

This is solved