This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Sqs kube2iam 0.11 #1025
Merged
Sqs kube2iam 0.11 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XXL
|
/assign @matzew |
|
The following is the coverage report on the affected files.
|
|
wow, nice work! I was assuming that was going to be way worse to do. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AceHack, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Backporting
#993
#986
Proposed Changes
Added the ability for AwsSqsSource CRD to expose pod annotations, this will allow for using Kube2IAM credentials. The existing credentials file is also supported. This is a backward-compatible change.
Fixing issue with incorrect conversion of sqs SentTimestamp
Release Note
Docs
Since this is a backport docs not updated