Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Don't advance the consumer group when events can't be delivered. #1030

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Don't advance the consumer group when events can't be delivered. #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kafka/channel/pkg/dispatcher/dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ type consumerMessageHandler struct {

func (c consumerMessageHandler) Handle(ctx context.Context, message *sarama.ConsumerMessage) (bool, error) {
event := fromKafkaMessage(ctx, message)
return true, c.dispatcher.DispatchEventWithDelivery(ctx, *event, c.sub.SubscriberURI, c.sub.ReplyURI, &c.sub.Delivery)
err := c.dispatcher.DispatchEventWithDelivery(ctx, *event, c.sub.SubscriberURI, c.sub.ReplyURI, &c.sub.Delivery)
// NOTE: only return `true` here if DispatchEventWithDelivery actually delivered the message.
return err == nil, err
}

var _ kafka.KafkaConsumerHandler = (*consumerMessageHandler)(nil)
Expand Down